From 839600ed703ccffbdb71bd2f04fb379d0920da95 Mon Sep 17 00:00:00 2001 From: x2048 Date: Sun, 31 Jul 2022 21:57:13 +0200 Subject: [PATCH] Use legacy image implementation (no NNAA filter) when not using 9-slice image (#12608) --- src/gui/guiFormSpecMenu.cpp | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/src/gui/guiFormSpecMenu.cpp b/src/gui/guiFormSpecMenu.cpp index 342ef0e18..5d4ca6747 100644 --- a/src/gui/guiFormSpecMenu.cpp +++ b/src/gui/guiFormSpecMenu.cpp @@ -825,12 +825,27 @@ void GUIFormSpecMenu::parseImage(parserData* data, const std::string &element) core::rect middle; if (parts.size() >= 4) parseMiddleRect(parts[3], &middle); + + // Temporary fix for issue #12581 in 5.6.0. + // Use legacy image when not rendering 9-slice image because GUIAnimatedImage + // uses NNAA filter which causes visual artifacts when image uses alpha blending. - GUIAnimatedImage *e = new GUIAnimatedImage(Environment, data->current_parent, - spec.fid, rect); + gui::IGUIElement *e; + if (middle.getArea() > 0) { + GUIAnimatedImage *image = new GUIAnimatedImage(Environment, data->current_parent, + spec.fid, rect); - e->setTexture(texture); - e->setMiddleRect(middle); + image->setTexture(texture); + image->setMiddleRect(middle); + e = image; + } + else { + gui::IGUIImage *image = Environment->addImage(rect, data->current_parent, spec.fid, nullptr, true); + image->setImage(texture); + image->setScaleImage(true); + image->grab(); // compensate for drop in addImage + e = image; + } auto style = getDefaultStyleForElement("image", spec.fname); e->setNotClipped(style.getBool(StyleSpec::NOCLIP, m_formspec_version < 3));