From 4297ae029d00bff0b68ef8542592f0726f83fd89 Mon Sep 17 00:00:00 2001
From: mckaygerhard <mckaygerhard@gmail.com>
Date: Mon, 29 Apr 2024 10:35:00 -0400
Subject: [PATCH] Fixed a crash due to vague or illogical comparisons for
 mummies

* seems the mummy is a mob, and `get_objects_inside_radius` also
  gets players, dropped items, etc... cos this function checks
  for all loaded entities on the server, so you'll need to check
  for that mummy around if those objects are only mobs, or not mobs
  or players or nodes.. this check is not made by upstream stupid developer,
  he just said "works for me"! and close the issue
* that function may returns nil/null if the name of the object is
  not EXACT the same, as made `if lua.name == "tsm_pyramids:mummy_spawmer"`
  then that the name could fails in rare cases becouse is used as index
  also the comparison is made with same olbject that seems
  do not have much effect
* The error of a nul vector is related only to the engine!
* Closes https://codeberg.org/minetest-stuffs/minetest-mod-tsm_pyramids/issues/4
* Closes https://github.com/EdenLostMinetest/tsm_pyramids/issues/1
* Closes https://codeberg.org/Wuzzy/minetest_tsm_pyramids/issues/4
---
 mummy.lua | 33 ++++++++++++++++++++++++++-------
 1 file changed, 26 insertions(+), 7 deletions(-)

diff --git a/mummy.lua b/mummy.lua
index 106b9d5..b8739cf 100644
--- a/mummy.lua
+++ b/mummy.lua
@@ -101,17 +101,36 @@ local MUMMY_DEF = {
 }
 
 -- Returns true if a mummy spawner entity was found at pos.
--- If self is provided, this object does not count.
+-- If self is provided, upstream pointed that is not count but must be checked if are the same
 local function check_if_mummy_spawner_entity_exists(pos, self)
 	local ents = minetest.get_objects_inside_radius(pos, 0.5)
+	if not ents then return false end
 	for e=1, #ents do
-		if (not self) or (ents[e] ~= ents[e]) then
-			local lua = ents[e]:get_luaentity()
-			if lua then
-				if lua.name == "tsm_pyramids:mummy_spawner" then
-					-- entity found
-					return true
+		local objent = ents[e]
+		local lua = objent:get_luaentity()
+		if self then
+			if objent ~= self.object then
+				local sobj = self.object:get_luaentity()
+				if sobj.name then
+					if sobj.name == "tsm_pyramids:mummy_spawner" then return true end
+					if sobj.name == "mummy_spawner" then return true end
+				else
+					return false -- BUG could be a mob spawner but cannot get the name?
 				end
+			else
+				return false -- same object, is duplicate cos "self" is provided!
+			end
+		else
+			if type(lua) ~= "userdata" then -- not a player could be a spawner or a node
+				if lua then
+					-- entity found
+					if lua.name then
+						if lua.name == "tsm_pyramids:mummy_spawner" then return true end
+						if lua.name == "mummy_spawner" then return true end
+					end
+				end
+			else
+				return false
 			end
 		end
 	end