minetest
/
minetest
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Player::getSpeed/setSpeed use const refs

master
Loic Blot 2017-08-14 10:56:06 +02:00
parent ab9f3b92f2
commit 3eb9ff555f
No known key found for this signature in database
GPG Key ID: EFAA458E8C153987
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/camera.cpp
View File

@ -526,7 +526,7 @@ void Camera::update(LocalPlayer* player, f32 frametime, f32 busytime,
// If the player is walking, swimming, or climbing, // If the player is walking, swimming, or climbing,
// view bobbing is enabled and free_move is off, // view bobbing is enabled and free_move is off,
// start (or continue) the view bobbing animation. // start (or continue) the view bobbing animation.
v3f speed = player->getSpeed(); const v3f &speed = player->getSpeed();
const bool movement_XZ = hypot(speed.X, speed.Z) > BS; const bool movement_XZ = hypot(speed.X, speed.Z) > BS;
const bool movement_Y = fabs(speed.Y) > BS; const bool movement_Y = fabs(speed.Y) > BS;

2
src/clientiface.cpp
View File

@ -95,7 +95,7 @@ void RemoteClient::GetNextBlocks (
} }
v3f playerpos = sao->getBasePosition(); v3f playerpos = sao->getBasePosition();
v3f playerspeed = player->getSpeed(); const v3f &playerspeed = player->getSpeed();
v3f playerspeeddir(0,0,0); v3f playerspeeddir(0,0,0);
if(playerspeed.getLength() > 1.0*BS) if(playerspeed.getLength() > 1.0*BS)
playerspeeddir = playerspeed / playerspeed.getLength(); playerspeeddir = playerspeed / playerspeed.getLength();

4
src/player.h
View File

@ -104,12 +104,12 @@ public:
std::vector<CollisionInfo> *collision_info) std::vector<CollisionInfo> *collision_info)
{} {}
v3f getSpeed() const v3f &getSpeed() const
{ {
return m_speed; return m_speed;
} }
void setSpeed(v3f speed) void setSpeed(const v3f &speed)
{ {
m_speed = speed; m_speed = speed;
} }