minenux
/
minetest-mod-nssw
1
0
Fork 0
Code Pull Requests Releases Activity

More refactoring #15

Closed
ranguli wants to merge 1 commits from more-refactoring into main
pull from: more-refactoring
merge into: minenux:main
Conversation 2 Commits 1 Files Changed 3
ranguli commented 2022-01-31 17:12:51 -08:00 (Migrated from github.com)
There is no content yet.
ranguli commented 2022-01-31 18:43:39 -08:00 (Migrated from github.com)

@Beanzilla I managed to introduce two regressions in #5 where the amount of ammo in a weapon doesn't decrease after firing, and reloading no longer works properly (only 1/4 sound effects play, and none of the animations). If you happen to see anything that stands out as being responsible for that please let me know. I'm currently looking back at the diffs but having no luck tracing the root of the bug.

Ideally I can fix that regression and have it added to this PR. The last commit without the regression seems to be 17b77262d5618217cc455378c234ce9a52af8746.

@Beanzilla I managed to introduce two regressions in #5 where the amount of ammo in a weapon doesn't decrease after firing, and reloading no longer works properly (only 1/4 sound effects play, and none of the animations). If you happen to see anything that stands out as being responsible for that please let me know. I'm currently looking back at the diffs but having no luck tracing the root of the bug. Ideally I can fix that regression and have it added to this PR. The last commit without the regression seems to be [17b77262d5618217cc455378c234ce9a52af8746. ](https://github.com/Beanzilla/rangedweapons-1/commit/17b77262d5618217cc455378c234ce9a52af8746)
ranguli commented 2022-02-02 18:46:25 -08:00 (Migrated from github.com)

I'm going to close this PR, as I've come to the conclusion it will be faster and easier to rewrite from scratch than to try and debug + refactor the existing codebase. You're welcome to take a look if you want: https://github.com/ranguli/boomstick

I'm going to close this PR, as I've come to the conclusion it will be faster and easier to rewrite from scratch than to try and debug + refactor the existing codebase. You're welcome to take a look if you want: [https://github.com/ranguli/boomstick](https://github.com/ranguli/boomstick)
👍 1

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
  
Kind: bug

Something is not working   
Kind: duplicate

This issue or pull request already exists   
Kind: question

More information is needed   
Status: help

Need some help   
Status: invalid

Something is wrong   
Status: wontfix

This won't be fixed   
Type: enhance

New feature
No Label
Kind: bug
Kind: duplicate
Kind: question
Status: help
Status: invalid
Status: wontfix
Type: enhance
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: minenux/minetest-mod-nssw#15
There is no content yet.
Delete Branch "more-refactoring"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?